c++ - Cannot get ispunct or isspace to work, but isupper works fine. Can you help me? -


this code outputs number of capital letters. outputs nummarks , numspaces 0. i've tried sentence.c_str() same results. cannot understand what's happening.

cout << "please enter sentence using grammatically correct formatting." << endl; string sentence = getline(); int numspaces = 0; int nummarks = 0; int numcaps = 0; char words[sentence.length()]; for(int = 0; < sentence.length(); ++i) {     words[i] = sentence[i];     if(isspace(words[i]) == true)     {         numspaces++;     }     else if(ispunct(words[i]) == true)     {         nummarks++;     }     else if(isupper(words[i]) == true)     {         numcaps++;     } } cout << "\nnumber of spaces: " << numspaces; cout << "\nnumber of punctuation marks: " << nummarks; cout << "\nnumber of capital letters: " << numcaps;

edit: fixed problem. compiler weird. had remove == true , worked perfectly. information though. know future

the functions isspace, ispunct, isupper using have return type int. return 0 if not match, , non-zero if match. don't return 1, testing == true may fail though check succeeded.

change code be:

if ( isspace(words[i]) )   // no == true

and should start working (so long don't type extended characters - see below).

further info: there 2 different isupper functions in c++ (and same other 2 functions). are:

#include <cctype> int isupper(int ch)

and

#include <locale> template< class chart > bool isupper( chart ch, const locale& loc );

you using first one, legacy function coming c. using incorrectly passing char; argument must in range of unsigned char. related question.

so fix code properly, choose 1 of following 2 options (including right header):

 if ( isupper( static_cast<unsigned char>(words[i]) ) )

or 

if ( isupper( words[i], locale() ) )

other things: char words[sentence.length()]; illegal in standard c++; array dimensions must known @ compile-time. compiler implementing extension.

however redundant, write sentence[i] , not use words @ all.


Comments

Post a Comment

Popular posts from this blog

java - Spring Data JPA: Why findOne(id) executing delete query internally? -

i have 1 application using @manytomany annotation link 2 different entities 1 parent entity. not sure if have implemented properly. when execute .findone() on parent entity's repository find it, @ first fetch data along executing delete queries internally delete record mapping table (a table jpa creates after adding @manytomany annotation.). following generated sql queries , code snippet: java class @entity @table(name = "inventory") public class inventory { @id long id; // many other properties @manytomany(fetch=fetchtype.lazy) private list<stream> streams; @manytomany(fetch=fetchtype.lazy) private list<subject> subjects; } there no other annotation i've put in stream , subject entity class link inventory class. when run app, create following tables: inventory stream subject inventory_stream inventory_subject (inventory_stream , inventory_subject, 2 tables created automatically, don't k...
Read more

python - Mongodb How to add addtional information when aggregating? -

i beginner , wrote line pipeline works, wanna add other information output, screen name , or number of tweets.i tried add under $group gave me syntax error everytime here pipeline: def make_pipeline(): # complete aggregation pipeline pipeline = [ { '$match': { "user.statuses_count": {"$gt":99 }, "user.time_zone": "brasilia" } }, { "$group": { "_id": "$user.id", "followers": { "$max": "$user.followers_count" } } }, { "$sort": { "followers": -1 } }, { "$limit" : 1 } ]; i using on example : { "_id" : objectid("5304e2e3cc9e684aa98bef97"), "text" : "first week of school on :p", "in_reply_to_status_id" : null, "retweet_count" : null, ...
Read more

java - Incorrect order of records in M-M relationship in hibernate -

Image
i have 4 records in bridge table in mysql database. using @manytomany in hibernate, accurate order of employees incorrect incorrect of projects. following required material figure out doing mistake. this source. @entity @table(name="project") public class projectbean { @id @generatedvalue @column(name="project_id") private int projectid; @column(name="title") private string projecttitle; @manytomany(mappedby="projects") private collection<employeebean> employees; public projectbean() { employees = new arraylist<employeebean>(); } //getters & setters } @entity @table(name="employee") public class employeebean { @id @generatedvalue @column(name="employee_id") private int employee_id; @column(name="first_name") private string ...
Read more