Python connect 4 check win function -


i writing connect 4 game in can choose size of board. game works flawlessly board sizes gives me problems when board taller wide. keep getting index out of range errors , im not sure have done wrong. have right in terms of check function part giving me issues.

def checkowin(board):      boardheight = len(board)     boardwidth = len(board[0])     tile = 'o'     # check horizontal spaces     y in range(boardheight):         x in range(boardwidth - 3):             if board[x][y] == tile , board[x+1][y] == tile , board[x+2][y] == tile , board[x+3][y] == tile:                 return true      # check vertical spaces     x in range(boardwidth):         y in range(boardheight - 3):             if board[x][y] == tile , board[x][y+1] == tile , board[x][y+2] == tile , board[x][y+3] == tile:                 return true      # check / diagonal spaces     x in range(boardwidth - 3):         y in range(3, boardheight):             if board[x][y] == tile , board[x+1][y-1] == tile , board[x+2][y-2] == tile , board[x+3][y-3] == tile:                 return true      # check \ diagonal spaces     x in range(boardwidth - 3):         y in range(boardheight - 3):             if board[x][y] == tile , board[x+1][y+1] == tile , board[x+2][y+2] == tile , board[x+3][y+3] == tile:                 return true      return false

any or suggestions appreciated. in advance!

you've mixed dimensions, should set them way:

def checkowin(board):     boardheight = len(board[0])     boardwidth = len(board)

because when refer board[x], that's counting number of lists in board, , when refer board[x][y] that's referring length of 1 specific row in board. 

if board[x][y] == tile , board[x+1][y] == tile , board[x+2][y] == tile , board[x+3][y] == tile:

when flipped values function ran without errors.


Comments

Post a Comment

Popular posts from this blog

php - failed to open stream: HTTP request failed! HTTP/1.0 400 Bad Request -

this code i'm using find latitude , longitude of place: function coords($address){ echo $url="http://maps.googleapis.com/maps/api/geocode/json?address=".$address; $json = file_get_contents(urlencode($url)); $data = json_decode($json, true); print_r($data['results'][0]['geometry']['location']['lat']); print_r($data['results'][0]['geometry']['location']['lng']); } however returns warning: failed open stream: http request failed! http/1.0 400 bad request if use above code in simple procedure works fine not in function. note: have tried curl_init()... method produced same result? instead of encoding whole url encode address part. following code work fine $add='jamshoro phase 2'; $url="http://maps.googleapis.com/maps/api/geocode/json?address=".urlencode($add); $json = file_get_contents($url); $data = json_decode($json, true); print_r($data['r
Read more

java - How to filter a backspace keyboard input -

i have code gives message when key number pressed: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochararray().length - 1]; if (!(ch >= '0' && ch <= '9')) { system.out.println("the char entered not number"); t.consume(); } } }); now if press on wrong button , press backspace remove it, error message. how can add backspace input if statement? i have found answer: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochar
Read more

java - Show Soft Keyboard when EditText Appears -

i have code in android app, alert dialog , keyboard, , when dialog shown want keyboard appear. not , not sure why? here code: final alertdialog.builder alert = new alertdialog.builder(this); alert.settitle("title"); alert.setmessage("message"); final edittext input = new edittext(this); input.setinputtype(inputtype.type_class_number); alert.setview(input); input.setonfocuschangelistener(new view.onfocuschangelistener() { @override public void onfocuschange(view v, boolean hasfocus) { if (hasfocus) { log.i(tag, "in focus"); inputmethodmanager inputmethodmanager = (inputmethodmanager) getsystemservice(context.input_method_service); inputmethodmanager.showsoftinput(input, inputmethodmanager.show_implicit); } } }); but keyboard not appear though edit text in focus, , tell appear why, doesn't come up? thanks in advance.
Read more