Liquibase's DbDoc listing all changes as "Pending / Not yet ran" -


liquibase integrated our spring application , database migration executed during application startup phase.

when running dbdoc via maven plugin changes reported "pending changes (not yet ran)". cannot create diff view our next release.

the issue found spring bean uses classpath relative path changelog entries in databasechangelog table. when running dbdoc via maven plugin filepath relative maven project's root used.

the code of notranchangesetfilter cannot deal difference: http://grepcode.com/file/repo1.maven.org/maven2/org.liquibase/liquibase-core/3.3.2/liquibase/changelog/filter/notranchangesetfilter.java

particularly following comparison not work:

ranchangeset.getchangelog().equalsignorecase(changeset.getfilepath())

the methods return following values:

getchangelog(): classpath:changelog/5.3.3/nos_add_acp_data.xml getfilepath(): src/main/resources/changelog/5.3.3/nos_add_acp_data.xml

thus equalsignorecase comparison fails, results in changes being listed "pending / not yet ran".

is there known work-around? solution can imagine provide our own implementation of notranchangesetfilter , put on classpath before liquibase maven plugin gets executed. there other ideas or official fix this?

update 2015-04-30: after lot of debugging think path in databasechangelog table must normalized, before stored. additionally each tool must normalize path comparisons work. found following places in code comparisons fail current concept:

  • ranchangesetfilter.getranchangeset(): equalsignorecase() comparison
  • validatingvisitor.visit(): ranindex.get(changeset.tostring(false));
  • notranchangesetfilter.accepts(): equalsignorecase() comparison
  • ranchangeset.issame(): equalsignorecase() comparison

in latter there single "normalize()" method strips classpath: prefix path. in 1 of 4 places.

the dbdoc tool seems able work source code path relative maven project root , classpath path. there following configuration options in maven project:

<changelogfile>changelog/complete.xml</changelogfile> -> "classpath:" prefix missing in comparison  <changelogfile>src/main/resources/changelog/complete.xml</changelogfile> -> "src/main/resources" prefix in comparisons

btw, first optiom should documented in maven plugin documentation.

pull request make dbdoc maven plugin work: https://github.com/liquibase/liquibase/pull/413

regards, michael

you right difference due differences in filepath liquibase stores. each changeset identified combination of id+author+filepath need ensure filepath consistent across ways of running liquibase.

usually best way have changelog files in classpath , refer changelogs using paths relative classpath, such "changelog/5.3.3/nos_add_acp_data.xml".

i'm not sure how referencing files currently. if using 3.3.2, there issue related how includeall works spring has been addressed in 3.3.3 may running into.

otherwise, can use "logicalfilepath" attribute on root databasechangelog node hard-code liquibase uses path know same, referenced.


Comments

Post a Comment

Popular posts from this blog

php - failed to open stream: HTTP request failed! HTTP/1.0 400 Bad Request -

this code i'm using find latitude , longitude of place: function coords($address){ echo $url="http://maps.googleapis.com/maps/api/geocode/json?address=".$address; $json = file_get_contents(urlencode($url)); $data = json_decode($json, true); print_r($data['results'][0]['geometry']['location']['lat']); print_r($data['results'][0]['geometry']['location']['lng']); } however returns warning: failed open stream: http request failed! http/1.0 400 bad request if use above code in simple procedure works fine not in function. note: have tried curl_init()... method produced same result? instead of encoding whole url encode address part. following code work fine $add='jamshoro phase 2'; $url="http://maps.googleapis.com/maps/api/geocode/json?address=".urlencode($add); $json = file_get_contents($url); $data = json_decode($json, true); print_r($data['r
Read more

java - How to filter a backspace keyboard input -

i have code gives message when key number pressed: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochararray().length - 1]; if (!(ch >= '0' && ch <= '9')) { system.out.println("the char entered not number"); t.consume(); } } }); now if press on wrong button , press backspace remove it, error message. how can add backspace input if statement? i have found answer: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochar
Read more

java - Show Soft Keyboard when EditText Appears -

i have code in android app, alert dialog , keyboard, , when dialog shown want keyboard appear. not , not sure why? here code: final alertdialog.builder alert = new alertdialog.builder(this); alert.settitle("title"); alert.setmessage("message"); final edittext input = new edittext(this); input.setinputtype(inputtype.type_class_number); alert.setview(input); input.setonfocuschangelistener(new view.onfocuschangelistener() { @override public void onfocuschange(view v, boolean hasfocus) { if (hasfocus) { log.i(tag, "in focus"); inputmethodmanager inputmethodmanager = (inputmethodmanager) getsystemservice(context.input_method_service); inputmethodmanager.showsoftinput(input, inputmethodmanager.show_implicit); } } }); but keyboard not appear though edit text in focus, , tell appear why, doesn't come up? thanks in advance.
Read more