php - Long processing time on menu script -


i building out nested menu magento store working on. store has around 700 categories in total (that nested around 4 levels @ most) need spat out menu.

the code have written takes on average 2.5s process (tested using microtime).

i wondering if unavoidable given amount of categories need processed.

anyways, code have come (go easy front end dev trade): note: using code loop out cms pages in same fashion 

$type = mage::registry('current_category') ? 'category' : 'page';  if($type == 'category') {     $currentid = mage::registry('current_category')->getid();     $parentids = explode('/', mage::registry('current_category')->path);     $rootid = mage::app()->getstore()->getrootcategoryid(); }  else {     $currentid = mage::getsingleton('cms/page')->getid();     $parentids = mage::getsingleton('cms/page')->getpathids();     $rootid = 0; }  function checkchildhtml($parentid, $htmlstring) {     $string = '';     if($parentid != $rootid) {         $string = $htmlstring;     }     return $string; }  // recurse site tree , build out menu function buildchildmenu($type, $currentid, $parentid, $ischild, $parentids, $rootid) {      // appropriate collection based on type     if($type == 'category') {         $children = mage::getmodel('catalog/category')->getcollection()             ->addattributetoselect('*')             ->addattributetofilter('is_active', '1')             ->addattributetofilter('include_in_menu', '1')             ->addattributetofilter('parent_id', array('eq' => $parentid))             ->addattributetosort('position', 'asc');     }      else {         $children = mage::getmodel('cms/page')->getcollection()             ->addfieldtoselect('*')             ->addfieldtofilter('is_active', '1')             ->addfieldtofilter('include_in_menu', '1')             ->addfieldtofilter('parent_id', array('eq' => $parentid))             ->setorder('position','asc');     }      // todo check $parentid != $rootid little hacky, need dry     $html .= ($parentid != $rootid) ? '<ul>' : null;      // loop on categories @ current level     foreach($children $child) {          $childid = $child->getid();         $parent = (count($child->getchildren()) > 0) ? $child->getchildren() : false;         $classes = [];          // build out class lists         if($parent) {             $classes[] = 'parent';         }         if(in_array($childid, $parentids, true) || count($children) == 1) {             $classes[] = "current active";         }         if($childid == $currentid) {             $classes[] = "current-page";         }          // build out list item values appropriate type         if($type == 'category') {             $html .= checkchildhtml($parentid, '<li class="' . implode(' ', $classes) . '">' . ($parent ? '<button class="toggle"></button>' : null) . '<a href="' . $child->geturl() . '">' . $child->getname() . '</a>');         }          else {             $html .= checkchildhtml($parentid, '<li class="' . implode(' ', $classes) . '">' . ($parent ? '<button class="toggle"></button>' : null) . '<a href="' . $child->geturl() . '">' . $child->title . '</a>');         }          // append list html (if not root page)         if($parent) {             // categories below page             $html .= buildchildmenu($type, $currentid, $child->getid(), true, $parentids, $rootid);         }          // close list (if not root product page)         $html .= checkchildhtml($parentid, '</li>');     }      $html .= checkchildhtml($parentid, '</ul>');      return $html; }  // build out menu root level down $categorylisthtml = buildchildmenu($type, $currentid, $rootid, false, $parentids, $rootid);

are there obvious bottlenecks here? if not, best practise in scenario?

for instance, should ajax children when requested? or maybe cache menu? or... else?

okay, issue had cache turned off whilst developing menu. cache enabled processing time insignificant.


Comments

Post a Comment

Popular posts from this blog

php - failed to open stream: HTTP request failed! HTTP/1.0 400 Bad Request -

this code i'm using find latitude , longitude of place: function coords($address){ echo $url="http://maps.googleapis.com/maps/api/geocode/json?address=".$address; $json = file_get_contents(urlencode($url)); $data = json_decode($json, true); print_r($data['results'][0]['geometry']['location']['lat']); print_r($data['results'][0]['geometry']['location']['lng']); } however returns warning: failed open stream: http request failed! http/1.0 400 bad request if use above code in simple procedure works fine not in function. note: have tried curl_init()... method produced same result? instead of encoding whole url encode address part. following code work fine $add='jamshoro phase 2'; $url="http://maps.googleapis.com/maps/api/geocode/json?address=".urlencode($add); $json = file_get_contents($url); $data = json_decode($json, true); print_r($data['r
Read more

java - How to filter a backspace keyboard input -

i have code gives message when key number pressed: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochararray().length - 1]; if (!(ch >= '0' && ch <= '9')) { system.out.println("the char entered not number"); t.consume(); } } }); now if press on wrong button , press backspace remove it, error message. how can add backspace input if statement? i have found answer: txtvalueofclause.addeventfilter(keyevent.key_typed, new eventhandler<keyevent>() { @override public void handle(keyevent t) { char ar[] = t.getcharacter().tochararray(); char ch = ar[t.getcharacter().tochar
Read more

java - Show Soft Keyboard when EditText Appears -

i have code in android app, alert dialog , keyboard, , when dialog shown want keyboard appear. not , not sure why? here code: final alertdialog.builder alert = new alertdialog.builder(this); alert.settitle("title"); alert.setmessage("message"); final edittext input = new edittext(this); input.setinputtype(inputtype.type_class_number); alert.setview(input); input.setonfocuschangelistener(new view.onfocuschangelistener() { @override public void onfocuschange(view v, boolean hasfocus) { if (hasfocus) { log.i(tag, "in focus"); inputmethodmanager inputmethodmanager = (inputmethodmanager) getsystemservice(context.input_method_service); inputmethodmanager.showsoftinput(input, inputmethodmanager.show_implicit); } } }); but keyboard not appear though edit text in focus, , tell appear why, doesn't come up? thanks in advance.
Read more