java - Consolidating Action Listeners of Buttons In Random Number Game -


i'm relatively new java, , had question game wrote. it's random number game try guess number 1-10 in least number of guesses.

i got program work, code seems inefficient. is, creating jbutton each number, creating separate action listener each button, (a lot has been omitted simplicity's sake , because irrelevant question):

note: int number = random number chosen program, , int guesscounter = number keeps track of number of guesses

 public class random extends jframe{   //creating buttons   jbutton 1 = new jbutton("1");  jbutton 2 = new jbutton("2");  jbutton 3 = new jbutton("3");      public static void main(string[] args){      //creating action listeners          oneclass uno = new oneclass();         one.addactionlistener(uno);          twoclass dos = new twoclass();         two.addactionlistener(dos);          threeclass tres = new threeclass();         three.addactionlistener(tres);          //action listener button 1          private class oneclass implements actionlistener{             public void actionperformed(actionevent event){                 if(number == 1){                     guesscounter++;                     joptionpane.showmessagedialog(null,"correct! guessed correct number in " + guesscounter + " guesses","correct!", joptionpane.plain_message);                 }else if(number > 1){                     guesscounter++;                     joptionpane.showmessagedialog(null,"incorrect. guess higher. have guessed " + guesscounter + " time(s).","incorrect", joptionpane.plain_message);                     one.setenabled(false);                 }else if(number < 1){                  }             }          }          //action listener button 2          private class twoclass implements actionlistener{             public void actionperformed(actionevent event){                 if(number == 2){                     guesscounter++;                     joptionpane.showmessagedialog(null,"correct! guessed correct number in " + guesscounter + " guesses","correct!", joptionpane.plain_message);                 }else if(number > 2){                     guesscounter++;                     joptionpane.showmessagedialog(null,"incorrect. guess higher. have guessed " + guesscounter + " time(s).","incorrect", joptionpane.plain_message);                     two.setenabled(false);                 }else if(number < 2){                     guesscounter++;                     joptionpane.showmessagedialog(null, "incorrect. guess lower. have guessed " + guesscounter + " time(s)","incorrect", joptionpane.plain_message);                     two.setenabled(false);                 }             }         }          //action listener button 3          private class threeclass implements actionlistener{             public void actionperformed(actionevent event){                 if(number == 3){                     guesscounter++;                     joptionpane.showmessagedialog(null,"correct! guessed correct number in " + guesscounter + " guesses","correct!", joptionpane.plain_message);                 }else if(number > 3){                     guesscounter++;                     joptionpane.showmessagedialog(null,"incorrect. guess higher. have guessed " + guesscounter + " time(s).","incorrect", joptionpane.plain_message);                     three.setenabled(false);                 }else if(number < 3){                     guesscounter++;                     joptionpane.showmessagedialog(null, "incorrect. guess lower. have guessed " + guesscounter + " time(s)","incorrect", joptionpane.plain_message);                     three.setenabled(false);                 }             }

one can see inefficiency can prevalent when each action listener long. my question is, possible condense (even if action listener each button requires random number compared different number)? long, , become extremely long start adding more difficult levels more numbers chose from.

yes, can write listener shared buttons. can "action command" of listener, text of button. can convert string actual number using integer.parseint(...) method. can invoke general logic.

here example of shared listener simulates keys of calculator:

import java.awt.*; import java.awt.event.*; import javax.swing.*; import javax.swing.border.*;  public class calculatorpanel extends jpanel {     private jtextfield display;      public calculatorpanel()     {         action numberaction = new abstractaction()         {             @override             public void actionperformed(actionevent e)             { //              display.setcaretposition( display.getdocument().getlength() );                 display.replaceselection(e.getactioncommand());             }         };          setlayout( new borderlayout() );          display = new jtextfield();         display.seteditable( false );         display.sethorizontalalignment(jtextfield.right);         add(display, borderlayout.north);          jpanel buttonpanel = new jpanel();         buttonpanel.setlayout( new gridlayout(0, 5) );         add(buttonpanel, borderlayout.center);          (int = 0; < 10; i++)         {             string text = string.valueof(i);             jbutton button = new jbutton( text );             button.addactionlistener( numberaction );             button.setborder( new lineborder(color.black) );             button.setpreferredsize( new dimension(50, 50) );             buttonpanel.add( button );              inputmap inputmap = button.getinputmap(jcomponent.when_in_focused_window);             inputmap.put(keystroke.getkeystroke(text), text);             inputmap.put(keystroke.getkeystroke("numpad" + text), text);             button.getactionmap().put(text, numberaction);         }     }      private static void createandshowui()     { //      uimanager.put("button.margin", new insets(10, 10, 10, 10) );          jframe frame = new jframe("calculator panel");         frame.setdefaultcloseoperation( jframe.exit_on_close );         frame.add( new calculatorpanel() );         frame.pack();         frame.setlocationrelativeto( null );         frame.setvisible(true);     }      public static void main(string[] args)     {         eventqueue.invokelater(new runnable()         {             public void run()             {                 createandshowui();             }         });     } }

Comments

Post a Comment

Popular posts from this blog

java - Spring Data JPA: Why findOne(id) executing delete query internally? -

i have 1 application using @manytomany annotation link 2 different entities 1 parent entity. not sure if have implemented properly. when execute .findone() on parent entity's repository find it, @ first fetch data along executing delete queries internally delete record mapping table (a table jpa creates after adding @manytomany annotation.). following generated sql queries , code snippet: java class @entity @table(name = "inventory") public class inventory { @id long id; // many other properties @manytomany(fetch=fetchtype.lazy) private list<stream> streams; @manytomany(fetch=fetchtype.lazy) private list<subject> subjects; } there no other annotation i've put in stream , subject entity class link inventory class. when run app, create following tables: inventory stream subject inventory_stream inventory_subject (inventory_stream , inventory_subject, 2 tables created automatically, don't k...
Read more

python - Mongodb How to add addtional information when aggregating? -

i beginner , wrote line pipeline works, wanna add other information output, screen name , or number of tweets.i tried add under $group gave me syntax error everytime here pipeline: def make_pipeline(): # complete aggregation pipeline pipeline = [ { '$match': { "user.statuses_count": {"$gt":99 }, "user.time_zone": "brasilia" } }, { "$group": { "_id": "$user.id", "followers": { "$max": "$user.followers_count" } } }, { "$sort": { "followers": -1 } }, { "$limit" : 1 } ]; i using on example : { "_id" : objectid("5304e2e3cc9e684aa98bef97"), "text" : "first week of school on :p", "in_reply_to_status_id" : null, "retweet_count" : null, ...
Read more

java - Incorrect order of records in M-M relationship in hibernate -

Image
i have 4 records in bridge table in mysql database. using @manytomany in hibernate, accurate order of employees incorrect incorrect of projects. following required material figure out doing mistake. this source. @entity @table(name="project") public class projectbean { @id @generatedvalue @column(name="project_id") private int projectid; @column(name="title") private string projecttitle; @manytomany(mappedby="projects") private collection<employeebean> employees; public projectbean() { employees = new arraylist<employeebean>(); } //getters & setters } @entity @table(name="employee") public class employeebean { @id @generatedvalue @column(name="employee_id") private int employee_id; @column(name="first_name") private string ...
Read more